-
Notifications
You must be signed in to change notification settings - Fork 463
📝(kubernetes) update doc with our dev-backend helm chart #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We removed the usage of bitnami charts and created our own dev-backend helm chart. We need to update the kubernetes document accordingly.
| host: impress.127.0.0.1.nip.io | ||
| host: docs.127.0.0.1.nip.io | ||
| annotations: | ||
| nginx.ingress.kubernetes.io/proxy-body-size: 10m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be better to increase, I think uploading bigger Word documents is very likely to happen.
StephanMeijer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, otherwise LGTM.
| DB_HOST: postgresql-dev-backend-postgres | ||
| DB_NAME: | ||
| secretKeyRef: | ||
| name: postgresql-dev-backend-postgres | ||
| key: database | ||
| DB_USER: | ||
| secretKeyRef: | ||
| name: postgresql-dev-backend-postgres | ||
| key: username | ||
| DB_PASSWORD: | ||
| secretKeyRef: | ||
| name: postgresql-dev-backend-postgres | ||
| key: password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the spacing correct here? Or should it be:
| DB_HOST: postgresql-dev-backend-postgres | |
| DB_NAME: | |
| secretKeyRef: | |
| name: postgresql-dev-backend-postgres | |
| key: database | |
| DB_USER: | |
| secretKeyRef: | |
| name: postgresql-dev-backend-postgres | |
| key: username | |
| DB_PASSWORD: | |
| secretKeyRef: | |
| name: postgresql-dev-backend-postgres | |
| key: password | |
| DB_HOST: postgresql-dev-backend-postgres | |
| DB_NAME: | |
| secretKeyRef: | |
| name: postgresql-dev-backend-postgres | |
| key: database | |
| DB_USER: | |
| secretKeyRef: | |
| name: postgresql-dev-backend-postgres | |
| key: username | |
| DB_PASSWORD: | |
| secretKeyRef: | |
| name: postgresql-dev-backend-postgres | |
| key: password |
Purpose
We removed the usage of bitnami charts and created our own dev-backend helm chart. We need to update the kubernetes document accordingly.
Proposal